[
https://issues.apache.org/jira/browse/SOLR-2245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050785#comment-14050785
]
Shalin Shekhar Mangar commented on SOLR-2245:
---------------------------------------------
Tim, I have reverted your commit because the licensing terms for greenmail
aren't clear. Their website says ASL 2.0 but I peeked into some of their source
files and all of them have a header saying that they are licensed according to
LGPL. This is a red flag and we need to tread carefully. There are plenty of
ASL projects using greenmail and maybe I am just being paranoid but after
consulting with Steve Rowe, I thought it safer to just revert the commit and
get more clarity on the licensing issue.
Example:
http://grepcode.com/file/repo1.maven.org/maven2/com.icegreen/greenmail/1.3.1b/com/icegreen/greenmail/store/MailMessageAttributes.java
> MailEntityProcessor Update
> --------------------------
>
> Key: SOLR-2245
> URL: https://issues.apache.org/jira/browse/SOLR-2245
> Project: Solr
> Issue Type: Improvement
> Components: contrib - DataImportHandler
> Affects Versions: 1.4, 1.4.1
> Reporter: Peter Sturge
> Assignee: Timothy Potter
> Priority: Minor
> Fix For: 4.9, 5.0
>
> Attachments: SOLR-2245.patch, SOLR-2245.patch, SOLR-2245.patch,
> SOLR-2245.patch, SOLR-2245.patch, SOLR-2245.zip
>
>
> This patch addresses a number of issues in the MailEntityProcessor
> contrib-extras module.
> The changes are outlined here:
> * Added an 'includeContent' entity attribute to allow specifying content to
> be included independently of processing attachments
> e.g. <entity includeContent="true" processAttachments="false" . . . />
> would include message content, but not attachment content
> * Added a synonym called 'processAttachments', which is synonymous to the
> mis-spelled (and singular) 'processAttachement' property. This property
> functions the same as processAttachement. Default= 'true' - if either is
> false, then attachments are not processed. Note that only one of these should
> really be specified in a given <entity> tag.
> * Added a FLAGS.NONE value, so that if an email has no flags (i.e. it is
> unread, not deleted etc.), there is still a property value stored in the
> 'flags' field (the value is the string "none")
> Note: there is a potential backward compat issue with FLAGS.NONE for clients
> that expect the absence of the 'flags' field to mean 'Not read'. I'm
> calculating this would be extremely rare, and is inadviasable in any case as
> user flags can be arbitrarily set, so fixing it up now will ensure future
> client access will be consistent.
> * The folder name of an email is now included as a field called 'folder'
> (e.g. folder=INBOX.Sent). This is quite handy in search/post-indexing
> processing
> * The addPartToDocument() method that processes attachments is significantly
> re-written, as there looked to be no real way the existing code would ever
> actually process attachment content and add it to the row data
> Tested on the 3.x trunk with a number of popular imap servers.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
