[
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051377#comment-14051377
]
Mark Miller commented on SOLR-5473:
-----------------------------------
I'm personally frustrated as well. I feel like I've been giving feed back on
this for a ton of months now and that it hasn't affected anything but variable
names and minor cleanup.
I'm sorry recently was not a good time - I had vacation, work trips, and a lot
of work and personal issues stacked on me. I only have the time I have to
contribute. It feels like the time I put in early trying to get my concerns in
before too much work was underway was ignored anyway though. This is exactly
what was planned from day one that I had objections too, just slightly cleaned
up.
I still think these API's need to be done right. I think such minimal effort
has gone into that so far, that I don't feel very bad blocking this. All the
work has gone into making it work (which is a big step, and I do think from
that perspective, it's good stuff), and very little has gone into making the
code and API changes sensible, or into expanding the tests in the areas that
are being changed.
I also think this issue is severely mistitled, and there is not a lot of
clarity on how you are changing cluster state caching and watchers and what
pro's and con's that change has.
Like I said, a user (and these are user API's to explore the clusterstate too)
or a developer will be lost trying to deal with this. I think it needs to be
addressed in code, but even if that didn't happen, a ton more could certainly
be addressed with comments and documentation that is not.
> Make one state.json per collection
> ----------------------------------
>
> Key: SOLR-5473
> URL: https://issues.apache.org/jira/browse/SOLR-5473
> Project: Solr
> Issue Type: Sub-task
> Components: SolrCloud
> Reporter: Noble Paul
> Assignee: Noble Paul
> Fix For: 5.0
>
> Attachments: SOLR-5473-74 .patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch,
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-configname-fix.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch,
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473_undo.patch,
> ec2-23-20-119-52_solr.log, ec2-50-16-38-73_solr.log
>
>
> As defined in the parent issue, store the states of each collection under
> /collections/collectionname/state.json node
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
