----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23371/#review47521 -----------------------------------------------------------
trunk/solr/core/src/java/org/apache/solr/cloud/OverseerAutoReplicaFailoverThread.java <https://reviews.apache.org/r/23371/#comment83460> don't think this needs to be volatile since it's no longer static. trunk/solr/core/src/java/org/apache/solr/cloud/OverseerAutoReplicaFailoverThread.java <https://reviews.apache.org/r/23371/#comment83461> From JIRA: "The API is a bit confusing, b/c this is the only function that takes a ZkStateReader – I think this is just b/c you want to test this function. Can the test just create one of these objects but not start it to simplify the API?" trunk/solr/core/src/java/org/apache/solr/cloud/OverseerAutoReplicaFailoverThread.java <https://reviews.apache.org/r/23371/#comment83507> What happens if the overseer dies after this request is made but before it succeeds? Is it possible that some other node takes over, does the same calculation and recovers the same replica to a new or different node? Maybe not a huge deal, but it could prevent some other replica from recovering because of maxShardsPerNode limitations. trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXmlOld.java <https://reviews.apache.org/r/23371/#comment83462> Experation -> Expiration trunk/solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java <https://reviews.apache.org/r/23371/#comment83448> just return here? trunk/solr/core/src/test/org/apache/solr/cloud/SharedFSAutoReplicaFailoverTest.java <https://reviews.apache.org/r/23371/#comment83457> Check collection2 as well? trunk/solr/core/src/test/org/apache/solr/cloud/SharedFSAutoReplicaFailoverTest.java <https://reviews.apache.org/r/23371/#comment83458> Check collection2 as well? trunk/solr/core/src/test/org/apache/solr/cloud/SharedFSAutoReplicaFailoverTest.java <https://reviews.apache.org/r/23371/#comment83459> Check collection2 as well? trunk/solr/core/src/test/org/apache/solr/cloud/SharedFSAutoReplicaFailoverUtilsTest.java <https://reviews.apache.org/r/23371/#comment83499> Made some comments in the jira about how I think this could be more understandable. trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterStateUtil.java <https://reviews.apache.org/r/23371/#comment83441> this one is seconds, the other milliseconds trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterStateUtil.java <https://reviews.apache.org/r/23371/#comment83442> this one in seconds, the other milliseconds trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterStateUtil.java <https://reviews.apache.org/r/23371/#comment83440> how long trunk/solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java <https://reviews.apache.org/r/23371/#comment83433> I asked this on the JIRA, why is maxShardPerNode being checked but not replication factor? https://cwiki.apache.org/confluence/display/solr/Collections+API says replication factor is required, but not maxShards? Also, why does getMaxShardsPerNode return an int but getReplicationFactor an Integer? - Gregory Chanan On July 9, 2014, 5:36 p.m., Mark Miller wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23371/ > ----------------------------------------------------------- > > (Updated July 9, 2014, 5:36 p.m.) > > > Review request for lucene. > > > Bugs: SOLR-5656 > https://issues.apache.org/jira/browse/SOLR-5656 > > > Repository: lucene > > > Description > ------- > > First svn patch for SOLR-5656: Add autoAddReplicas feature for shared file > systems. > > > Diffs > ----- > > trunk/solr/cloud-dev/control.sh 1608973 > trunk/solr/cloud-dev/functions.sh 1608973 > trunk/solr/cloud-dev/solrcloud-start-existing.sh 1608973 > trunk/solr/cloud-dev/solrcloud-start.sh 1608973 > trunk/solr/cloud-dev/stop.sh 1608973 > > trunk/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestSolrEntityProcessorEndToEnd.java > 1608973 > trunk/solr/core/src/java/org/apache/solr/cloud/Assign.java 1608973 > trunk/solr/core/src/java/org/apache/solr/cloud/CloudUtil.java PRE-CREATION > trunk/solr/core/src/java/org/apache/solr/cloud/ElectionContext.java 1608973 > trunk/solr/core/src/java/org/apache/solr/cloud/Overseer.java 1608973 > > trunk/solr/core/src/java/org/apache/solr/cloud/OverseerAutoReplicaFailoverThread.java > PRE-CREATION > > trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java > 1608973 > trunk/solr/core/src/java/org/apache/solr/cloud/ZkController.java 1608973 > trunk/solr/core/src/java/org/apache/solr/core/ConfigSolr.java 1608973 > trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXml.java 1608973 > trunk/solr/core/src/java/org/apache/solr/core/ConfigSolrXmlOld.java 1608973 > trunk/solr/core/src/java/org/apache/solr/core/CoreContainer.java 1608973 > trunk/solr/core/src/java/org/apache/solr/core/DirectoryFactory.java 1608973 > trunk/solr/core/src/java/org/apache/solr/core/HdfsDirectoryFactory.java > 1608973 > > trunk/solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java > 1608973 > > trunk/solr/core/src/java/org/apache/solr/handler/admin/CoreAdminHandler.java > 1608973 > trunk/solr/core/src/java/org/apache/solr/request/LocalSolrQueryRequest.java > 1608973 > trunk/solr/core/src/java/org/apache/solr/update/HdfsUpdateLog.java 1608973 > trunk/solr/core/src/java/org/apache/solr/update/UpdateShardHandler.java > 1608973 > trunk/solr/core/src/test-files/log4j.properties 1608973 > trunk/solr/core/src/test-files/solr/solr-no-core.xml 1608973 > trunk/solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java > 1608973 > > trunk/solr/core/src/test/org/apache/solr/cloud/ChaosMonkeyShardSplitTest.java > 1608973 > trunk/solr/core/src/test/org/apache/solr/cloud/ClusterStateUpdateTest.java > 1608973 > > trunk/solr/core/src/test/org/apache/solr/cloud/CollectionsAPIDistributedZkTest.java > 1608973 > trunk/solr/core/src/test/org/apache/solr/cloud/CustomCollectionTest.java > 1608973 > trunk/solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java > 1608973 > trunk/solr/core/src/test/org/apache/solr/cloud/MigrateRouteKeyTest.java > 1608973 > > trunk/solr/core/src/test/org/apache/solr/cloud/OverseerCollectionProcessorTest.java > 1608973 > trunk/solr/core/src/test/org/apache/solr/cloud/OverseerRolesTest.java > 1608973 > trunk/solr/core/src/test/org/apache/solr/cloud/OverseerTest.java 1608973 > trunk/solr/core/src/test/org/apache/solr/cloud/ShardRoutingCustomTest.java > 1608973 > trunk/solr/core/src/test/org/apache/solr/cloud/ShardSplitTest.java 1608973 > > trunk/solr/core/src/test/org/apache/solr/cloud/SharedFSAutoReplicaFailoverTest.java > PRE-CREATION > > trunk/solr/core/src/test/org/apache/solr/cloud/SharedFSAutoReplicaFailoverUtilsTest.java > PRE-CREATION > trunk/solr/core/src/test/org/apache/solr/cloud/ZkControllerTest.java > 1608973 > trunk/solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java > 1608973 > > trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java > 1608973 > > trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandlerBackup.java > 1608973 > trunk/solr/core/src/test/org/apache/solr/search/TestRecoveryHdfs.java > 1608973 > trunk/solr/core/src/test/org/apache/solr/util/MockConfigSolr.java > PRE-CREATION > trunk/solr/example/solr/solr.xml 1608973 > > trunk/solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java > 1608973 > trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClosableThread.java > 1608973 > trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java > 1608973 > > trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterStateUtil.java > PRE-CREATION > trunk/solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java > 1608973 > trunk/solr/solrj/src/java/org/apache/solr/common/cloud/SolrZkClient.java > 1608973 > trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java > 1608973 > > trunk/solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleTestBase.java > 1608973 > > trunk/solr/solrj/src/test/org/apache/solr/client/solrj/TestLBHttpSolrServer.java > 1608973 > > trunk/solr/solrj/src/test/org/apache/solr/client/solrj/embedded/JettyWebappTest.java > 1608973 > > trunk/solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java > 1608973 > trunk/solr/test-framework/src/java/org/apache/solr/SolrJettyTestBase.java > 1608973 > > trunk/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java > 1608973 > trunk/solr/test-framework/src/java/org/apache/solr/cloud/ChaosMonkey.java > 1608973 > > trunk/solr/test-framework/src/java/org/apache/solr/cloud/CloudInspectUtil.java > 1608973 > > trunk/solr/test-framework/src/java/org/apache/solr/cloud/MockSolrZkClient.java > PRE-CREATION > > trunk/solr/test-framework/src/java/org/apache/solr/cloud/MockZkStateReader.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23371/diff/ > > > Testing > ------- > > > Thanks, > > Mark Miller > >
