[
https://issues.apache.org/jira/browse/SOLR-6245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-6245:
----------------------------------------
Attachment: SOLR-6245.patch
Moved the testcase into a new test so that we can use SupressSSL annotation on
it. I cannot reconcile the SSL configuration with the new HttpComponents API
and I don't have time to work on it further. But coverage wise we're good
because the fix is adequately tested.
> Socket and Connection configuration are ignored in HttpSolrServer when
> passing in HttpClient
> --------------------------------------------------------------------------------------------
>
> Key: SOLR-6245
> URL: https://issues.apache.org/jira/browse/SOLR-6245
> Project: Solr
> Issue Type: Bug
> Components: clients - java
> Affects Versions: 4.7, 4.8, 4.9
> Reporter: Patanachai Tangchaisin
> Assignee: Shalin Shekhar Mangar
> Attachments: SOLR-6245.patch, SOLR-6245.patch, SOLR-6245.patch
>
>
> I spent time debugging our HttpSolrServer and HttpClient. We construct our
> HttpClient (we have some requirement regarding about connectionTimeout,
> soTimeout, etc.) and then pass it to HttpSolrServer. I found out that all our
> socket level and connection level configuration are ignored when creating a
> http connection.
> The problem is in HttpClient 4.3.X, they allow overriding of these parameters
> per request i.e. one request can have socketTimeout=100ms and another request
> can have socketTimeout=200ms. The logic[1] to check whether to make it
> per-request base config or not depending on whether any of these parameters
> is set.
> {code}
> protected NamedList<Object> executeMethod(HttpRequestBase method, final
> ResponseParser processor) throws SolrServerException {
> // XXX client already has this set, is this needed?
> method.getParams().setParameter(ClientPNames.HANDLE_REDIRECTS,
> followRedirects);
> method.addHeader("User-Agent", AGENT);
> {code}
> In HttpSolrServer.java, only one parameter (HANDLE_REDIRECTS) is set but that
> trigger the logic in HttpClient to initialize a default per-request base
> config, which eventually override any socket and connection configuration, we
> did via HttpClientBuilder.
> To conclude, a solution would be to remove these line
> {code}
> // XXX client already has this set, is this needed?
> method.getParams().setParameter(ClientPNames.HANDLE_REDIRECTS,
> followRedirects);
> {code}
> [1] -
> http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/InternalHttpClient.java?revision=1603745&view=markup
> [LINE:172]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
