[
https://issues.apache.org/jira/browse/LUCENE-2649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12968458#action_12968458
]
Ryan McKinley commented on LUCENE-2649:
---------------------------------------
looks good to me
bq. we instantiate vals.values lazily for some reason... and then at the end,
if it still hasn't been instantiated, we do it anyway?
I don't know about this, I just copied from the existing code...
We could make the case where Bits.MatchNoBits( maxDoc ), have a null array.
This would make your proposed change invalid though since it checks the array
first.
bq. I'm still trying to grok the logic of calling checkMatchAllBits only if
vals.valid == null... seems like it will always return null in that case?
The assumption is that once vals.valid is set, it should not be recalculated.
The reasons for the if vals.valie == null in the validate function are:
- the vals.valid Bits may have been set in fillXXValues
- the first call may have excluded checkMatchAllBits, and a subsequet call
has it set
Are you asking about in the validate function? If so, fillXXXValues can set
the vals.valid, so it does not do it again.
> FieldCache should include a BitSet for matching docs
> ----------------------------------------------------
>
> Key: LUCENE-2649
> URL: https://issues.apache.org/jira/browse/LUCENE-2649
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Ryan McKinley
> Assignee: Ryan McKinley
> Fix For: 4.0
>
> Attachments: LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch,
> LUCENE-2649-FieldCacheWithBitSet.patch, LUCENE-2649-FieldCacheWithBitSet.patch
>
>
> The FieldCache returns an array representing the values for each doc.
> However there is no way to know if the doc actually has a value.
> This should be changed to return an object representing the values *and* a
> BitSet for all valid docs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
