[ 
https://issues.apache.org/jira/browse/LUCENE-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14063372#comment-14063372
 ] 

Robert Muir commented on LUCENE-5828:
-------------------------------------

Is this really correct? if i make a slice 0-5 out of length 10 and then read 6 
bytes from it, what happens?

> Improve BufferedIndexInput.SlicedIndexInput to directly delegate
> ----------------------------------------------------------------
>
>                 Key: LUCENE-5828
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5828
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>         Attachments: LUCENE-5828.patch
>
>
> Currently we have some IndexInputs which do not have a separate slice() 
> implementation. Those are using BufferedIndexInput#wrap(), which extends 
> BufferedInputStream. This is nonsense, because the underlying IndexInput is 
> in most cases already Buffered, and if not, its not needed.
> This issue will change SlicedIndexInput to directly delegate, correcting 
> offsets. The new class SlicedIndexInput will be top level and public.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to