[ https://issues.apache.org/jira/browse/LUCENE-5831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065164#comment-14065164 ]
Steve Rowe commented on LUCENE-5831: ------------------------------------ Simple patch: {code:xml} Index: build.xml =================================================================== --- build.xml (revision 1611400) +++ build.xml (working copy) @@ -39,7 +39,7 @@ <property name="tests.heap-dump-dir" location="heapdumps"/> <target name="precommit" description="Run basic checks before committing" - depends="check-svn-working-copy,validate,documentation-lint"/> + depends="clean-jars,check-svn-working-copy,validate,documentation-lint"/> <target name="test" description="Test both Lucene and Solr"> <subant buildpath="." antfile="extra-targets.xml" target="-run-test" inheritall="false" failonerror="true" /> {code} > ant precommit should depend on clean-jars > ----------------------------------------- > > Key: LUCENE-5831 > URL: https://issues.apache.org/jira/browse/LUCENE-5831 > Project: Lucene - Core > Issue Type: Bug > Components: general/build > Reporter: Steve Rowe > Priority: Minor > > Ivy's bug that fails to remove differently versioned dependencies in > (test-)lib/ dirs even though we set {{sync="true"}} on {{<ivy:retrieve>}} (I > couldn't find a JIRA for this) continues to cause trouble/confusion (see > related LUCENE-5467). > We should make the ant {{precommit}} target depend on {{clean-jars}}, so that > people won't think they need to run {{ant jar-checksums}} because of stale > jars Ivy leaves in {{lib/}} or {{test-lib/}} directories, which currently > causes {{ant precommit}} to bitch that there are missing checksums. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org