[
https://issues.apache.org/jira/browse/LUCENE-5813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065487#comment-14065487
]
Adrien Grand commented on LUCENE-5813:
--------------------------------------
I don' t think using {{instanceof Accountable}} works in general to measure
memory usage. That's what I initially wanted to do with doc id sets, but this
doesn't work as soon as you start using wrappers since they hide what interface
the wrapped class implements. So for example if your NRT dir wraps a
RateLimitedDirectoryWrapper that wraps another directory that implements
Accountable, you would miss it.
If we don't want of Accountable on Directory, I would rather revert LUCENE-5812
to make clear that it only reports memory usage for the cache?
> Directory should implement Accountable
> --------------------------------------
>
> Key: LUCENE-5813
> URL: https://issues.apache.org/jira/browse/LUCENE-5813
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 4.10
>
> Attachments: LUCENE-5813.patch
>
>
> Follow-up of LUCENE-5812.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
