[
https://issues.apache.org/jira/browse/LUCENE-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14068664#comment-14068664
]
Michael McCandless commented on LUCENE-5836:
--------------------------------------------
+1 for BytesRefBuilder!
> BytesRef.copyBytes and copyChars don't oversize
> -----------------------------------------------
>
> Key: LUCENE-5836
> URL: https://issues.apache.org/jira/browse/LUCENE-5836
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Attachments: LUCENE-5836.patch
>
>
> When copying data from another BytesRef/CharSequence, these methods don't
> oversize. This is not an issue if this method is used only once per BytesRef
> instance but I just reviewed the usage of these methods and they are very
> frequently used in loops to do things like:
> - keep track of the top values in comparators
> - keep track of the previous terms in various loops over a terms enum
> (lucene49 DV consumer, BlockTreeTermsWriter)
> - etc.
> Although unlikely, it might be possible to hit a worst-case and to resize the
> underlying byte[] on every call to copyBytes? Should we oversize the
> underlying array in these methods?
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
