[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076949#comment-14076949
]
Robert Muir commented on LUCENE-5850:
-------------------------------------
{quote}
But we cannot get the minor version for each segment. So we have to decide if
we write the bugfix version number to index file (x.y.z.a.b.c... as many as you
like). If we do this, we need the validation of LUCENE_MAIN_VERSION (smoker and
-> see below).
{quote}
I think we should: because its the version of lucene that wrote the segment. It
is possible we may need to differentiate 4.8.1 from 4.8 for some hackedy-hack
in the future because of say, a bug unrelated to the format (perhaps in
indexwriter or something). So if we write the correct version we always have
the possibility to add workarounds for such things.
> Constants#LUCENE_MAIN_VERSION can have broken values
> -----------------------------------------------------
>
> Key: LUCENE-5850
> URL: https://issues.apache.org/jira/browse/LUCENE-5850
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.3.1, 4.5.1
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5850.patch, LUCENE-5850_bomb.patch,
> LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should
> not contain minor versions. Well this is at least what I thought and to my
> knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we
> broke this such that the version from SegmentsInfo can not be parsed with
> Version#parseLeniently. IMO we should really add an assertion that this
> constant doesn't throw an error and / or make the smoketester catch this. to
> me this is actually a index BWC break. Note that 4.8.1 doesn't have this
> problem...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
