[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079217#comment-14079217
]
Robert Muir commented on LUCENE-5850:
-------------------------------------
{quote}
I disagree. Version.java was and is never intended to be used to specifiy real
Lucene versions. Version is there to enable backwards compatibility hacks when
passing in as constant to enable backwards compatibility hacks. We also remove
older constants!
Elasticsearch and Shai Erea were simply doing the completely wrong thing...
{quote}
Of course, but the version "system" is so complicated that nobody here can even
seem to agree about what should be written in the index.
This is a big fucking problem.
I'm telling you one thing: we are going to simplify this versioning, or we are
going to simplify (aka reduce) our back compat guarantee. I'll be the first to
opt out of providing back compat: its a feature that people who care about can
contribute.
I'm ready to go this route if you cannot simply agree that this is all a
confusing mess.
> Constants#LUCENE_MAIN_VERSION can have broken values
> -----------------------------------------------------
>
> Key: LUCENE-5850
> URL: https://issues.apache.org/jira/browse/LUCENE-5850
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.3.1, 4.5.1
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5850.patch, LUCENE-5850.patch,
> LUCENE-5850_bomb.patch, LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should
> not contain minor versions. Well this is at least what I thought and to my
> knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we
> broke this such that the version from SegmentsInfo can not be parsed with
> Version#parseLeniently. IMO we should really add an assertion that this
> constant doesn't throw an error and / or make the smoketester catch this. to
> me this is actually a index BWC break. Note that 4.8.1 doesn't have this
> problem...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
