[
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14079265#comment-14079265
]
Shai Erera commented on LUCENE-5859:
------------------------------------
The thing that worries me is that if you upgrade your app from 4.8 to 4.9 and a
FooAnalyzer changed runtime behavior, and you didn't read the CHANGES, your app
will break silently or loudly, depending on the back-compat break. And you may
not notice that break until it's too late.
At least with Codecs, you cannot continue to index w/ a Foo48Codec because we
remove the indexing classes and you will get a RuntimeException. That's why I
proposed the Foo48Analyzer, so a Foo49Analyzer does not silently break your
app, and if you upgrade your app to use it, then it's your responsibility to
understand the changes and determine what needs to be done in your app.
I'm not against the proposal here, just raising some concerns that I have.
Going w/ a no-Version ctor does not address the silent break you may experience
if you don't read the CHANGES ...
> add no-Version parameter to Analyzers/QueryParser
> -------------------------------------------------
>
> Key: LUCENE-5859
> URL: https://issues.apache.org/jira/browse/LUCENE-5859
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: 5.0
>
>
> This has always been a mess: analyzers are easy enough to make on your own,
> we don't need to "take responsibility" for the users analysis chain for 2
> major releases.
> The code maintenance is horrible here.
> This creates a huge usability issue too, and as seen from numerous mailing
> list issues, users don't even understand how this versioning works anyway.
> I'm sure someone will whine if i try to remove these constants, but we can at
> least make no-arg ctors forwarding to VERSION_CURRENT so that people who
> don't care about back compat (e.g. just prototyping) don't have to deal with
> the horribly complex versioning system.
> If you want to make the argument that doing this is "trappy" (i heard this
> before), i think thats bogus, and ill counter by trying to remove them.
> Either way, I'm personally not going to add any of this kind of back compat
> logic myself ever again.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
