[
https://issues.apache.org/jira/browse/LUCENE-5864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080677#comment-14080677
]
Uwe Schindler commented on LUCENE-5864:
---------------------------------------
+1 for splitting up. I have not yet looked at the patch, but seeing and
documenting BytesRef just as a pointer with offset and length, but also
supplying methods that can change the pointer and contents looks wrong.
BytesRef is just a slice-pointer, nothing more - and it should behave like one.
> Split BytesRef into BytesRef and BytesRefBuilder
> ------------------------------------------------
>
> Key: LUCENE-5864
> URL: https://issues.apache.org/jira/browse/LUCENE-5864
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Fix For: 4.10
>
> Attachments: LUCENE-5864.patch
>
>
> Follow-up of LUCENE-5836.
> The fact that BytesRef (and CharsRef, IntsRef, LongsRef) can be used as
> either pointers to a section of a byte[] or as buffers raises issues. The
> idea would be to keep BytesRef but remove all the buffer methods like
> copyBytes, grow, etc. and add a new class BytesRefBuilder that wraps a byte[]
> and a length (but no offset), has grow/copyBytes/copyChars methods and the
> ability to build BytesRef instances.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
