[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-5850:
----------------------------------
Attachment: LUCENE-5850.patch
Small updates after chat with Robert: Improve documentation
There is a small change now for release managers:
As we now write the full version number into index files (including bugfix),
after branching a release we have to update common-build.xml and Constants.java
to have the bugfix number already. This is needed to have LUCENE_MAIN_VERSION
already contain the bugfix number. This is checked by the common-build file. So
you cannot release "4.10.0" without editing common-build.xml to be valid. The
only difference between releases and other builds is the version suffix
"SNAPSHOT".
I will update the release manager instructions after this is done.
For Robert: _THIS PATCH DOES NOT HANDLE Version.java MERGE. IT JUST UPDATES TO
NEW LUCENE_MAIN_VERSION_SEMANTICS (full bugfix) and improves documentation, so
problems like ES and Shai's error cannot happen anymore._
> Constants#LUCENE_MAIN_VERSION can have broken values
> -----------------------------------------------------
>
> Key: LUCENE-5850
> URL: https://issues.apache.org/jira/browse/LUCENE-5850
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.3.1, 4.5.1
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5850.patch, LUCENE-5850.patch, LUCENE-5850.patch,
> LUCENE-5850.patch, LUCENE-5850.patch, LUCENE-5850_bomb.patch,
> LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should
> not contain minor versions. Well this is at least what I thought and to my
> knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we
> broke this such that the version from SegmentsInfo can not be parsed with
> Version#parseLeniently. IMO we should really add an assertion that this
> constant doesn't throw an error and / or make the smoketester catch this. to
> me this is actually a index BWC break. Note that 4.8.1 doesn't have this
> problem...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
