[ 
https://issues.apache.org/jira/browse/LUCENE-5860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081436#comment-14081436
 ] 

Uwe Schindler edited comment on LUCENE-5860 at 7/31/14 8:43 PM:
----------------------------------------------------------------

Hi Mike,

I am fine with that improvement. I am just a bit confused: For numeric trie 
terms the maximum and minimum values are not quite right (because of the 
additional shift!=0 terms)? As far as I remember, the min/max value is the 
found by binary search? Or is it now changed that min/max values come from the 
min/max shift=0 term? If thats the case I am fine, otherwise I think the binary 
search is more costly.

Sorry did not yet look at the patch in more detail, at least not at 
NumericUtils.


was (Author: thetaphi):
Hi Mike,

I am fine with that improvement. I am just a bit confused: For numeric trie 
terms the maximum and minimum values are not quite right. As far as I remember, 
the min/max value is the found by binary search? Or is it now changed that 
min/max values come from the min/max shift=0 term? If thats the case I am fine, 
otherwise I think the binary search is more costly.

Sorry did not yet look at the patch in more detail, at least not at 
NumericUtils.

> Use Terms.getMin/Max to speed up range queries/filters
> ------------------------------------------------------
>
>                 Key: LUCENE-5860
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5860
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.0, 4.10
>
>         Attachments: LUCENE-5860.patch
>
>
> As of LUCENE-5610, Lucene's Terms API now exposes min and max terms in
> each field.  I think we can use this in our term/numeric range
> query/filters to avoid visiting a given segment by detecting up front
> that the terms in the segment don't overlap with the query's range.
> Even though block tree avoids disk seeks in certain cases when the
> term cannot exist on-disk, I think this change would further avoid
> disk seeks in additional cases because the min/max term has
> more/different information than the in-memory FST terms index.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to