[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086142#comment-14086142
]
Uwe Schindler edited comment on LUCENE-5850 at 8/5/14 11:50 AM:
----------------------------------------------------------------
Sorry Robert it is. In 4.9.1 it would write LUCENE_MAIN_VERSION with "4.9". My
earlier fix enforces this. If you would use LUCENE_MAIN_VERSION="4.9.1" it
would fail to run tests already.
The bugs were in older versions that has an incorrect value. The bugs are
indeed older 4.5.1 and 4.3.1 versions. See Simon's original issue description.
was (Author: thetaphi):
Sorry Robert it is. In 4.9.1 it would write LUCENE_MAIN_VERSION with "4.9". My
earlier fix enforces this. If you would use LUCENE_MAIN_VERSION="4.9.1" it
would fail to run tests already.
> Constants#LUCENE_MAIN_VERSION can have broken values
> -----------------------------------------------------
>
> Key: LUCENE-5850
> URL: https://issues.apache.org/jira/browse/LUCENE-5850
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.3.1, 4.5.1
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5850.patch, LUCENE-5850.patch, LUCENE-5850.patch,
> LUCENE-5850.patch, LUCENE-5850.patch, LUCENE-5850.patch,
> LUCENE-5850_bomb.patch, LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should
> not contain minor versions. Well this is at least what I thought and to my
> knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we
> broke this such that the version from SegmentsInfo can not be parsed with
> Version#parseLeniently. IMO we should really add an assertion that this
> constant doesn't throw an error and / or make the smoketester catch this. to
> me this is actually a index BWC break. Note that 4.8.1 doesn't have this
> problem...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
