[ https://issues.apache.org/jira/browse/LUCENE-5870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086433#comment-14086433 ]
Uwe Schindler commented on LUCENE-5870: --------------------------------------- +1 In my opinion, I would use methods of Double/Float/... that directly return an instance, like Double.valueOf() instead of autoboxing Double.parseDouble() and so on. In 4.x we may still need some special case, because we have a backwards layer for early 3.x indexes there (like 3.2 or so). > Simplify StoredFieldsVisitor > ---------------------------- > > Key: LUCENE-5870 > URL: https://issues.apache.org/jira/browse/LUCENE-5870 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Adrien Grand > Assignee: Adrien Grand > Fix For: 5.0, 4.10 > > Attachments: LUCENE-5870.patch > > > StoredFieldVisitor has a visitor method for 4 numeric types: int, long, float > and double. We should remove this specialization and just have a method that > takes a java.lang.Number. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org