[ 
https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086441#comment-14086441
 ] 

Ryan Ernst commented on LUCENE-5871:
------------------------------------

I don't think we should deprecate something that is only in trunk.  We should 
simply change trunk, as 5.0 is not released.  I am suggesting replacing the 
logic depending on version with an explicit option in IWC.  It will default to 
current behavior (as if we saw LUCENE_5_0 currently), but can be set to use the 
semantics of 4x (commit on close). 

> Simplify or remove use of Version in IndexWriterConfig
> ------------------------------------------------------
>
>                 Key: LUCENE-5871
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5871
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ryan Ernst
>
> {{IndexWriter}} currently uses Version from {{IndexWriterConfig}} to 
> determine the semantics of {{close()}}.  This is a trapdoor for users, as 
> they often default to just sending Version.LUCENE_CURRENT since they don't 
> understand what it will be used for.  Instead, we should make the semantics 
> of close a direction option in IWC.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to