[ 
https://issues.apache.org/jira/browse/SOLR-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14090630#comment-14090630
 ] 

ASF GitHub Bot commented on SOLR-6336:
--------------------------------------

GitHub user andyetitmoves opened a pull request:

    https://github.com/apache/lucene-solr/pull/81

    Cache children as well so that they can be returned when the watcher is 
reused

    Fixes an issue with apache/lucene-solr#80 pulled to SOLR-6336. If the first 
`getChildren` actually returns nodes, and the second request happens before the 
watch is fired, currently it will return no children.
    
    The rest of the patch is just minor code cleanup.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bloomberg/lucene-solr trunk-reuse-latch-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/81.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #81
    
----
commit f603e7506d1fe5d956a75cdb13897b1b7af7ac70
Author: Ramkumar Aiyengar <andyetitmo...@gmail.com>
Date:   2014-08-08T07:44:10Z

    Cache children as well so that they can be returned when the watcher is 
reused

----


> DistributedQueue (and it's use in OCP) leaks ZK Watches
> -------------------------------------------------------
>
>                 Key: SOLR-6336
>                 URL: https://issues.apache.org/jira/browse/SOLR-6336
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Ramkumar Aiyengar
>            Assignee: Mark Miller
>
> The current {{DistributedQueue}} implementation leaks ZK watches whenever it 
> finds children or times out on finding one. OCP uses this in its event loop 
> and can loop tight in some conditions (when exclusivity checks fail), leading 
> to lots of watches which get triggered together on the next event (could be a 
> while for some activities like shard splitting).
> This gets exposed by SOLR-6261 which spawns a new thread for every parallel 
> watch event.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to