[
https://issues.apache.org/jira/browse/LUCENE-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14096726#comment-14096726
]
Adrien Grand commented on LUCENE-5884:
--------------------------------------
Thanks for taking care of this, Caching memory usage of the root arcs in
FST.java will certainly help!
There is just one thing that looked wrong to me: in
UpToTwoPositiveIntOutputs.java you return {{BASE_TWO_INTS_NUM_BYTES +
RamUsageEstimator.sizeOf(tl.first) + RamUsageEstimator.sizeOf(tl.second);}} but
I think it should be just {{BASE_TWO_INTS_NUM_BYTES}} since the two longs that
it carries are not wrappers (java.util.Long) but primitive longs.
> Speed up FST.ramBytesUsed
> -------------------------
>
> Key: LUCENE-5884
> URL: https://issues.apache.org/jira/browse/LUCENE-5884
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5884.patch, LUCENE-5884.patch
>
>
> It's a little heavy now, relying too much on reflection
> (RUE.shallowSizeOf)... and we do this up to 128 times per FST (= per indexed
> field, per segment, for the terms index).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
