[ 
https://issues.apache.org/jira/browse/LUCENE-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104434#comment-14104434
 ] 

Dawid Weiss commented on LUCENE-5896:
-------------------------------------

So, to be clear -- I think this is the problem:
{code}
public static IndexWriterConfig newIndexWriterConfig(Random r, Analyzer a) {
{code}
It should just use the randomized context's randomness consistently instead of 
accepting an external Random. It would be consistent (and is not leading to any 
thread related randomization races).

> A few potential reproducible issues
> -----------------------------------
>
>                 Key: LUCENE-5896
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5896
>             Project: Lucene - Core
>          Issue Type: Test
>          Components: general/test
>    Affects Versions: 4.9
>            Reporter: Simon Willnauer
>             Fix For: 5.0, 4.10
>
>         Attachments: LUCENE-5896.patch
>
>
> I realized that passing the same seeded random instance to LuceneTestCase# 
> newIndewWriterConfig doesn't necessarily produce the same IWC and I found a 
> bunch of issues in that class using global random rather than local random. 
> Yet, I went over the file to spot others but we might need to think about a 
> more automated way to spot those...



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to