[
https://issues.apache.org/jira/browse/LUCENE-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104452#comment-14104452
]
Dawid Weiss commented on LUCENE-5896:
-------------------------------------
Ok, clear. I would really encourage removing Random as a parameter in favor of
grabbing a random() locally inside a method that needs it (or use adequate
methods from the superclass). When there are loops that do millions of
iterations and performance becomes an issue, fork off a local variable with
{code}
Random local = new Random(randomLong());
...
{code}
Ideally, it shouldn't escape outside of the method scope.
> A few potential reproducibility issues
> --------------------------------------
>
> Key: LUCENE-5896
> URL: https://issues.apache.org/jira/browse/LUCENE-5896
> Project: Lucene - Core
> Issue Type: Test
> Components: general/test
> Affects Versions: 4.9
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5896.patch
>
>
> I realized that passing the same seeded random instance to LuceneTestCase#
> newIndewWriterConfig doesn't necessarily produce the same IWC and I found a
> bunch of issues in that class using global random rather than local random.
> Yet, I went over the file to spot others but we might need to think about a
> more automated way to spot those...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
