[ https://issues.apache.org/jira/browse/SOLR-6405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107153#comment-14107153 ]
Jessica Cheng Mallet commented on SOLR-6405: -------------------------------------------- Should the "if (attemptCount > 0)" check be removed in retryDelay, now that the sleep is (attemptCount + 1) * retryDelay? I think in practice we'd never miss the initial 1.5s sleep since the padding on the retryDelay is enough to make up for it, but it's slightly harder to reason about. (The way I thought it worked was that roughly retry count is calculated so 1+2+3+4+...+retryCount ~= timeoutSec, so when that's multiplied by 1.5x (the retryDelay), we have the timeout covered. Is this right?) > ZooKeeper calls can easily not be retried enough on ConnectionLoss. > ------------------------------------------------------------------- > > Key: SOLR-6405 > URL: https://issues.apache.org/jira/browse/SOLR-6405 > Project: Solr > Issue Type: Bug > Components: SolrCloud > Reporter: Mark Miller > Assignee: Mark Miller > Priority: Critical > Fix For: 5.0, 4.10 > > Attachments: SOLR-6405.patch > > > The current design requires that we are sure we retry on connection loss > until session expiration. -- This message was sent by Atlassian JIRA (v6.2#6252) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org