[
https://issues.apache.org/jira/browse/LUCENE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107218#comment-14107218
]
Uwe Schindler edited comment on LUCENE-5898 at 8/22/14 6:13 PM:
----------------------------------------------------------------
Now the only remaining files with version numbers are solr/example config file:
{noformat}
./lucene/CHANGES.txt:======================= Lucene 5.0.0
=======================
./lucene/core/src/test/org/apache/lucene/util/TestVersion.java:
assertEquals(Version.LUCENE_5_0_0, Version.parse("5.0.0"));
./lucene/version.properties:version.base=5.0.0
./solr/CHANGES.txt:================== 5.0.0 ==================
Binary file ./solr/contrib/map-reduce/lib/Saxon-HE-9.5.1-4.jar matches
./solr/example/example-DIH/solr/db/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/example-DIH/solr/mail/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/example-DIH/solr/rss/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/example-DIH/solr/solr/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/example-DIH/solr/tika/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/example-schemaless/solr/collection1/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/multicore/core0/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/multicore/core1/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/solr/collection1/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
{noformat}
was (Author: thetaphi):
Now the only remaining files with version numbers are solr/example config file:
{noformat}
./solr/example/example-DIH/solr/db/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/example-DIH/solr/mail/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/example-DIH/solr/rss/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/example-DIH/solr/solr/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/example-DIH/solr/tika/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/example-schemaless/solr/collection1/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/multicore/core0/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/multicore/core1/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
./solr/example/solr/collection1/conf/solrconfig.xml:
<luceneMatchVersion>5.0.0</luceneMatchVersion>
{noformat}
> Cleanup version handling in build files
> ---------------------------------------
>
> Key: LUCENE-5898
> URL: https://issues.apache.org/jira/browse/LUCENE-5898
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 5.0, 4.11
>
> Attachments: LUCENE-5898-2.patch, LUCENE-5898-2.patch,
> LUCENE-5898-2.patch, LUCENE-5898.patch
>
>
> We have still some duplicates in build files. RM must change the base version
> at many places after release.
> There is also a bug "Specification-Version:" in JAR files must be numeric
> only. So I sill set it to {{$\{version.base\}}} which is guaranteed to be
> numeric only. This is why we had the separate property in common-build. This
> needs to be fixed in 4.10 - not for relaese - but for development on release
> branch!
> This issue cleans a lot up:
> - Use spec.version with version.base as value
> - In Maven inject more version numbers, so RM does not need to change
> anything in POM templates
> - Remove useless attributes from some macros
> - Inject version numbers also to eclipse/idea/...
> - Don't define version properties a second time in root's build.xml (because
> it does not include common-build, its duplicated there - I will fix this, too)
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
