[ https://issues.apache.org/jira/browse/LUCENE-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970981#action_12970981 ]
Michael McCandless commented on LUCENE-2811: -------------------------------------------- Committed to trunk... I'll let this age a bit before backporting to 3.x. > SegmentInfo should explicitly track whether that segment wrote term vectors > --------------------------------------------------------------------------- > > Key: LUCENE-2811 > URL: https://issues.apache.org/jira/browse/LUCENE-2811 > Project: Lucene - Java > Issue Type: Bug > Components: Index > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: 3.1, 4.0 > > Attachments: LUCENE-2811.patch > > > Today SegmentInfo doesn't know if it has vectors, which means its files() > method must check if the files exist. > This leads to subtle bugs, because Si.files() caches the files but then we > fail to invalidate that later when the term vectors files are created. > It also leads to sloppy code, eg TermVectorsReader "gracefully" handles being > opened when the files do not exist. I don't like that; it should only be > opened if they exist. > This also fixes these intermittent failures we've been seeing: > {noformat} > junit.framework.AssertionFailedError: IndexFileDeleter doesn't know about > file _1e.tvx > at > org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:979) > at > org.apache.lucene.util.LuceneTestCase$LuceneTestCaseRunner.runChild(LuceneTestCase.java:917) > at > org.apache.lucene.index.IndexWriter.filesExist(IndexWriter.java:3633) > at > org.apache.lucene.index.IndexWriter.startCommit(IndexWriter.java:3699) > at > org.apache.lucene.index.IndexWriter.prepareCommit(IndexWriter.java:2407) > at > org.apache.lucene.index.IndexWriter.commitInternal(IndexWriter.java:2478) > at org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:2460) > at org.apache.lucene.index.IndexWriter.commit(IndexWriter.java:2444) > at > org.apache.lucene.index.TestIndexWriterExceptions.testRandomExceptionsThreads(TestIndexWriterExceptions.java:213) > {noformat} -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org