No big deal, Erick. Thanks for catching this, it wasn't a trivial issue! Dawid
On Mon, Sep 1, 2014 at 10:16 PM, Erick Erickson <[email protected]> wrote: > Dawid: > > Sorry, I didn't make it clear that I intended to commit it to both trunk and > 4.x, running full test suite now. > > I looked it over and I see what you were talking about. I hadn't looked > before, my error invoking the tests and producing this error was getting in > the way of my _real_ test and I didn't have the energy. > > You're totally right, static member vars for _anything_ but simple immutable > data is usually A Bad Thing. > > Thanks again! > Erick > > > > On Mon, Sep 1, 2014 at 12:56 PM, Dawid Weiss <[email protected]> > wrote: >> >> > Awww, man, do I have to? I didn't write the test, I just accidentally >> > tripped it by messing up the tests command ;).. >> >> Stop moaning, soldier! :) >> >> > Seriously, thanks! It's always a Good Thing to dive a little deeper, >> > I'll try to get my head around it today. >> >> You don't *have to*, but it wouldn't hurt if there were two people who >> actually understand what happened there. :) >> >> And more seriously, if you could at least commit it to trunk and >> backport to 4x it'd still be helpful -- I'll be away (from Lucene) >> tomorrow. >> >> Dawid >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
