[ 
https://issues.apache.org/jira/browse/SOLR-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118824#comment-14118824
 ] 

Yonik Seeley commented on SOLR-6472:
------------------------------------

bq. This is really annoying because you can forget to add the '!' character at 
the end and you wouldn't even know why the request was routed incorrectly.

A system wouldn't forget to add that "!" though.

But really, this was done on purpose as a feature.  Routing currently works 
with individual documents... if you leave off the bang, you're saying "target 
the shard containing this doc".   Of course there have been a number of changes 
to the routing code since the first commit, and I haven't verified that it 
still works.


> Don't require an '!' character at the end of a _route_ (shard.keys) value
> -------------------------------------------------------------------------
>
>                 Key: SOLR-6472
>                 URL: https://issues.apache.org/jira/browse/SOLR-6472
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrCloud
>            Reporter: Shalin Shekhar Mangar
>            Priority: Minor
>              Labels: SolrCloud, difficulty-easy, impact-low
>             Fix For: 4.11
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> A routing key can be specified in the "_route_" parameter which is then 
> hashed and the shard corresponding to the key is selected for 
> querying/indexing. But we require users to specify an exclamation mark at the 
> end to get the right routing otherwise it fails silently or gives the wrong 
> hash. This also applies to the split.key param used in shard splitting.
> This is really annoying because you can forget to add the '!' character at 
> the end and you wouldn't even know why the request was routed incorrectly.
> We should make the '!' character optional and support keys both with and 
> without it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to