Yeah, like I said, the main sticking points after we agreed on the architecture change and you pulled zkstatereader from clusterstate were the doc and some naming. I didn't change how anything was done. There is more I'd like to do in terms of refactoring, but I don't have the time short term and it's stuff that can be done later.
- Mark > On Sep 3, 2014, at 5:22 PM, Noble Paul <[email protected]> wrote: > > The changes are not much from my patch , so , it looks fine > > >> On Wed, Sep 3, 2014 at 1:30 PM, Mark Miller <[email protected]> wrote: >> >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/24220/ >> >> Review request for lucene. >> By Mark Miller. >> Updated Sept. 3, 2014, 8:30 p.m. >> >> Changes >> >> New patch to pass precommit (hopefull - having some troubles with libversion >> on my mac air) >> Repository: lucene >> Description >> >> Split clusterstate.json per collection and watch states selectively >> >> >> Diffs (updated) >> >> trunk/solr/core/src/java/org/apache/solr/cloud/Overseer.java (1622312) >> trunk/solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java >> (1622312) >> trunk/solr/core/src/java/org/apache/solr/cloud/ZkController.java (1622312) >> trunk/solr/core/src/java/org/apache/solr/handler/admin/CollectionsHandler.java >> (1622312) >> trunk/solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java >> (1622312) >> trunk/solr/core/src/java/org/apache/solr/servlet/ZookeeperInfoServlet.java >> (1622312) >> trunk/solr/core/src/test/org/apache/solr/cloud/ClusterStateFormat2Test.java >> (PRE-CREATION) >> trunk/solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrServer.java >> (1622312) >> trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java >> (1622312) >> trunk/solr/solrj/src/java/org/apache/solr/common/cloud/DocCollection.java >> (1622312) >> trunk/solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java >> (1622312) >> trunk/solr/solrj/src/test/org/apache/solr/client/solrj/impl/CloudSolrServerTest.java >> (1622312) >> trunk/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java >> (1622312) >> trunk/solr/webapp/web/css/styles/cloud.css (1622312) >> trunk/solr/webapp/web/js/scripts/cloud.js (1622312) >> trunk/solr/webapp/web/tpl/cloud.html (1622312) >> View Diff >> > > > > -- > ----------------------------------------------------- > Noble Paul
