I have potential use for MiniSolrCloudCluster, and was just poking
around at the code and a couple of improvements came to mind,
wondering if I'm going off the deep end here.
1> It seems like the methods in TestMiniSolrCloudCluster
> uploadConfigToZk
> uploadConfigFileToZk
> createCollection
> waitForRecoveriesToFinish
should be moved to MiniSolrCloudCluster. It strikes me that these
methods would be generally useful for any test subclassing
MiniSolrCloudCluster. Which I intend to do I think.
2> There exist two rules:
@Rule
public TestRule solrTestRules = RuleChain
.outerRule(new SystemPropertiesRestoreRule());
@ClassRule
public static TestRule solrClassRules = RuleChain.outerRule(
new SystemPropertiesRestoreRule()).around(
new RevertDefaultThreadHandlerRule());
yet the shutdown() method explicitly clears a bunch of system
properties. I'm a little fuzzy on the ClassRule above, but is clearing
the system props really necessary in the shutdown method? And if I
move the methods to the MiniSolrCloudCluster that set the system
props, I assume that I should move both rules to the base class too.
And a special bonus for anyone who can give me a clue why both are
needed, it's late and I'm going to sleep on it before tracking it
down.
Just to be clear, if people think these changes are a good idea, I'll
take care of it as part of what I'm working on now.
Thanks!
Erick
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
