[ 
https://issues.apache.org/jira/browse/LUCENE-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14121364#comment-14121364
 ] 

Robert Muir commented on LUCENE-5906:
-------------------------------------

Previously the test just ignored the return value from delete.

Maybe it doesn't need to delete at all. But i saw this newDir created as:
{code}
File newDir = new File(h.getCore().getDataDir() + "index_temp");
{code}

So I was afraid to remove the delete() (and replaced it with a picky one), 
because i don't know if this directory is a child of one called from 
LuceneTestCase (which is guaranteed to be cleaned up correctly) or instead 
created in some arbitrary way.

> Use Files.delete instead of File.delete + made up exception
> -----------------------------------------------------------
>
>                 Key: LUCENE-5906
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5906
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-5906.patch, LUCENE-5906.patch, LUCENE-5906.patch
>
>
> We are on java7, if we cannot delete a file, this one returns a real 
> exception as to why.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to