I thought it is an extremely trivial fix. That's why I didn't add it to changes.txt. I shall do it On Sep 5, 2014 7:15 PM, "Hoss Man (JIRA)" <[email protected]> wrote:
> > [ > https://issues.apache.org/jira/browse/SOLR-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Hoss Man reopened SOLR-6457: > ---------------------------- > > This needs a CHANGES.txt noting the bug fix and giving longkeyy credit for > the contribution. > > > LBHttpSolrServer: AIOOBE risk if counter overflows > > -------------------------------------------------- > > > > Key: SOLR-6457 > > URL: https://issues.apache.org/jira/browse/SOLR-6457 > > Project: Solr > > Issue Type: Bug > > Components: clients - java > > Affects Versions: 4.0, 4.1, 4.2, 4.2.1, 4.3, 4.3.1, 4.4, 4.5, 4.5.1, > 4.6, 4.6.1, 4.7, 4.7.1, 4.7.2, 4.8, 4.8.1, 4.9 > > Reporter: longkeyy > > Assignee: Noble Paul > > Labels: patch > > Attachments: SOLR-6457.patch > > > > > > org.apache.solr.client.solrj.impl.LBHttpSolrServer > > line 442 > > int count = counter.incrementAndGet(); > > ServerWrapper wrapper = serverList[count % serverList.length]; > > when counter overflows, the mod operation of > > "count % serverList.length" will start trying to use negative numbers as > array indexes. > > suggess to fixup it ,eg: > > //keep count is greater than 0 > > int count = counter.incrementAndGet() & 0x7FFFFFF; > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
