[ 
https://issues.apache.org/jira/browse/SOLR-2288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated SOLR-2288:
------------------------------

    Attachment: SOLR-2288_namedlist.patch

Hi Hoss Man, thanks for starting this issue.

I looked at your patch, and personally I think NamedList should really be 
type-safe.
If users want to use it in a type-unsafe way, thats fine, but the container 
itself shouldn't be List<Object>.

Here's an initial patch (all tests pass)... it also removes the deprecated 
methods.


> clean up compiler warnings
> --------------------------
>
>                 Key: SOLR-2288
>                 URL: https://issues.apache.org/jira/browse/SOLR-2288
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>         Attachments: SOLR-2288_namedlist.patch, warning.cleanup.patch
>
>
> there's a ton of compiler warning in the solr tree, and it's high time we 
> cleaned them up, or annotate them to be suppressed so we can start making a 
> bigger stink when/if code is added to the tree thta produces warnings (we'll 
> never do a good job of noticing new warnings when we have ~175 existing ones)
> Using this issue to track related commits
> The goal of this issue should not be to change any functionality or APIs, 
> just deal with each warning in the most appropriate way;
> * fix generic declarations
> * add SuppressWarning anotation if it's safe in context

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to