[ https://issues.apache.org/jira/browse/LUCENE-5934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128766#comment-14128766 ]
Michael McCandless commented on LUCENE-5934: -------------------------------------------- Can we move the codec check: {noformat} if ((si.getCodec() instanceof Lucene3xCodec) == false) { {noformat} up into SIS.write, just before: {noformat} if (!segmentWasUpgraded(directory, si)) { {noformat} ? This way if something like this tries to happen again in 4.x, at least we don't corrupt-on-kiss and instead just throw the exception and rollback the commit. > 4.10 broke backwards compatibility for 4.0 indexes > -------------------------------------------------- > > Key: LUCENE-5934 > URL: https://issues.apache.org/jira/browse/LUCENE-5934 > Project: Lucene - Core > Issue Type: Bug > Components: core/codecs, core/index > Affects Versions: 4.10 > Reporter: Robert Muir > Priority: Blocker > Fix For: 4.10.1, 4.11, 5.0 > > Attachments: LUCENE-5934.patch, LUCENE-5934.patch, LUCENE-5934.patch, > LUCENE-5934.patch, LUCENE-5934.patch > > > As reported by Ian on the user list: > Its trying to treat them as 3.x -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org