[
https://issues.apache.org/jira/browse/LUCENE-5930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Rowe updated LUCENE-5930:
-------------------------------
Attachment: LUCENE-5930.patch
The module groups look good, I didn't change them in this version of the patch.
I refactored the patch a bit so that the {{dev-tools/\*\*/\*.iml}} files are
svn move'd - that way their history stays intact and I can view diffs for them
in IntelliJ. Run the following svn commands before applying the patch:
{noformat}
svn mv dev-tools/idea/lucene/core/src/java/lucene-core.iml
dev-tools/idea/lucene/core/src/
svn mv dev-tools/idea/lucene/codecs/src/java/codecs.iml
dev-tools/idea/lucene/codecs/src/
svn mv dev-tools/idea/solr/core/src/test/solr-core-tests.iml
dev-tools/idea/solr/core/src/
svn mv dev-tools/idea/solr/solrj/src/test/solrj-tests.iml
dev-tools/idea/solr/solrj/src/
{noformat}
I also fixed up several other issues I found after running all the predefined
whole-module JUnit run configurations.
The main things I changed:
* Added {{lucene-core}} as a TEST dependency to {{solrj-tests.iml}}, so that
tests that need lucene utility class(es) will compile - I think this is the
problem you saw, Ryan.
* Reordered {{.idea/modules.xml}} by module group and then alphabetically, and
put the {{group}} attribute first in the XML tags.
* Added an {{@Ignore}} annotation to backward-codec module's
{{CreateBackwardsCompatibilityIndex}} so that IntelliJ won't run it.
* Removed the test output directory from {{lucene-core.iml}}, so that it
wouldn't be included in {{analysis-common}}'s test classpath; otherwise,
{{TestAllAnalyzersHaveFactories}} complains that
{{TrivialLookaheadTokenFilter}}, a Lucene core test class, can't be loaded via
SPI. (I also did the same thing in {{codecs.iml}} even though it isn't causing
a problem at this point, since test output only happens in the corresponding
test module.)
* Added {{src/resources/}} to {{sandbox.iml}} so that
{{IDVersionPostingsFormat}} is loadable via SPI.
* Added the Solr core test library to {{map-reduce.iml}} so that class
{{org.mortbay.jetty.Connector}} is loadable (from {{jetty-<version>.jar}},
which is only located in {{solr/core/test-lib/}}).
I started getting OOM Permgen errors half-way through the solr core JUnit
module run configuration (around 1,000/1,833 tests, all passing up to that
point), not sure how to configure that, so I didn't change that.
> IntelliJ config: drop resource-only modules, add module groups, and add
> module for lucene/backward-codecs
> ---------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-5930
> URL: https://issues.apache.org/jira/browse/LUCENE-5930
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Ryan Ernst
> Attachments: LUCENE-5930.patch, LUCENE-5930.patch, LUCENE-5930.patch
>
>
> The number of intellij modules is getting out of hand. Intellij supports
> marking subdirectories within a module as
> source/resources/tests/test-resources. I think we should consolidate these
> modules so we have just one per lucene module. Is there some reason I'm
> missing that this was not done in the first place?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
