[
https://issues.apache.org/jira/browse/LUCENE-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134452#comment-14134452
]
Uwe Schindler edited comment on LUCENE-5950 at 9/15/14 9:17 PM:
----------------------------------------------------------------
There are some changes in common-build that are wrong: The workaround for the
Ant bug is exactly like that, that we pass "build.compiler=javac1.7" for every
version >= 1.8, because Ant 1.8.3 and 1.8.4 have a bug, so we must pass
javac1.7 (see link supplied in comment). So don't change that condition!
Because we are now on minimum Java 8, you can set build.compiler always to
javac1.7 as workaround:
{code:xml}
<!-- workaround for https://issues.apache.org/bugzilla/show_bug.cgi?id=53347
-->
<condition property="build.compiler" value="javac1.7">
<or>
<antversion exactly="1.8.3" />
<antversion exactly="1.8.4" />
</or>
</condition>
{code}
Also some conditions/fails are commented out (also in root build.xml regarding
smoke tester). The "needed minimum Java 8" <fail/> was commented out, why?
was (Author: thetaphi):
There are some changes in common-build that are wrong: The workaround for the
Ant bug is exactly like that, that we pass "build.compiler=javac1.7" for every
version >= 1.8, because Ant 1.8.2 and 1.8.3 have a bug, so we must pass
javac1.7 (see link supplied in comment). So don't change that condition!
Because we are now on minimum Java 8, you can set build.compiler always to
javac1.7 as workaround:
{code:xml}
<!-- workaround for https://issues.apache.org/bugzilla/show_bug.cgi?id=53347
-->
<condition property="build.compiler" value="javac1.7">
<or>
<antversion exactly="1.8.3" />
<antversion exactly="1.8.4" />
</or>
</condition>
{code}
Also some conditions/fails are commented out (also in root build.xml regarding
smoke tester). The "needed minimum Java 8" <fail/> was commented out, why?
> Move to Java 8 in trunk
> -----------------------
>
> Key: LUCENE-5950
> URL: https://issues.apache.org/jira/browse/LUCENE-5950
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Ryan Ernst
> Attachments: LUCENE-5950.patch, LUCENE-5950.patch, LUCENE-5950.patch,
> LUCENE-5950.patch
>
>
> The dev list thread "[VOTE] Move trunk to Java 8" passed.
> http://markmail.org/thread/zcddxioz2yvsdqkc
> This issue is to actually move trunk to java 8.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
