[ https://issues.apache.org/jira/browse/LUCENE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135136#comment-14135136 ]
Michael McCandless commented on LUCENE-5952: -------------------------------------------- bq. Wait, it was lenient before. Right, SegmentInfo.getVersion was lenient before, i.e. we read a String and left it as a String in SegmentInfo. But then we needed to "compare leniently" which was also scary ... > Make Version.java lenient again? > -------------------------------- > > Key: LUCENE-5952 > URL: https://issues.apache.org/jira/browse/LUCENE-5952 > Project: Lucene - Core > Issue Type: Bug > Affects Versions: 4.10 > Reporter: Michael McCandless > Priority: Blocker > Fix For: 4.10.1, 4.11, 5.0 > > Attachments: LUCENE-5952.patch > > > As discussed on the dev list, it's spooky how Version.java tries to fully > parse the incoming version string ... and then throw exceptions that lack > details about what invalid value it received, which file contained the > invalid value, etc. > It also seems too low level to be checking versions (e.g. is not future proof > for when 4.10 is passed a 5.x index by accident), and seems redundant with > the codec headers we already have for checking versions? > Should we just go back to lenient parsing? -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org