[
https://issues.apache.org/jira/browse/LUCENE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135165#comment-14135165
]
Uwe Schindler edited comment on LUCENE-5952 at 9/16/14 9:20 AM:
----------------------------------------------------------------
bq. I agree ... I'll fix Lucene46SegmentInfoWriter/Reader to write as int ... I
think I'll use separate vInts: I don't like tying this "encoded format"
(stuffing 4 ints that are actually bytes into 1 int) to the index format.
Yeah, we should maybe add a method to Version that writes itsself to a
DataOutput: Version.writeVersion(DataOutput) and Version.readVersion(DataInput).
In any case, this is a separate issue, because it involves a index format
change, that we should not do in 4.10.1. I would suggest to change this for the
coming 5.0.
was (Author: thetaphi):
bq. I agree ... I'll fix Lucene46SegmentInfoWriter/Reader to write as int ... I
think I'll use separate vInts: I don't like tying this "encoded format"
(stuffing 4 ints that are actually bytes into 1 int) to the index format.
Yeah, we should maybe add a method to Version that writes itsself to a
DataOutput: Version.writeVersion(DataOutput).
In any case, this is a separate issue, because it involves a index format
change, that we should not do in 4.10.1. I would suggest to change this for the
coming 5.0.
> Make Version.java lenient again?
> --------------------------------
>
> Key: LUCENE-5952
> URL: https://issues.apache.org/jira/browse/LUCENE-5952
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: 4.10
> Reporter: Michael McCandless
> Priority: Blocker
> Fix For: 4.10.1, 4.11, 5.0
>
> Attachments: LUCENE-5952.patch, LUCENE-5952.patch
>
>
> As discussed on the dev list, it's spooky how Version.java tries to fully
> parse the incoming version string ... and then throw exceptions that lack
> details about what invalid value it received, which file contained the
> invalid value, etc.
> It also seems too low level to be checking versions (e.g. is not future proof
> for when 4.10 is passed a 5.x index by accident), and seems redundant with
> the codec headers we already have for checking versions?
> Should we just go back to lenient parsing?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
