[ https://issues.apache.org/jira/browse/LUCENE-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135892#comment-14135892 ]
Uwe Schindler commented on LUCENE-5952: --------------------------------------- I am happy with == false for more complex constructs, but this makes it hard to read because the API developer had another idea of how the code should look like. When I read that code it tooks me several branches in my own main processor to understand what that meen, because its unnatureal. The offical Sun/Oracle Code guidelines for Java also forbid this. If you are afraid to loose the !, just invert the if construct completely (thats what I mostly do!) FYI: If I see the first one writing a TokenStream like: {code:java} if (incrementToken() == false) ... {code} I will stop working on Lucene! Trust me! Really! :-) > Give Version parsing exceptions more descriptive error messages > --------------------------------------------------------------- > > Key: LUCENE-5952 > URL: https://issues.apache.org/jira/browse/LUCENE-5952 > Project: Lucene - Core > Issue Type: Bug > Affects Versions: 4.10 > Reporter: Michael McCandless > Priority: Blocker > Fix For: 4.10.1, 4.11, 5.0 > > Attachments: LUCENE-5952.patch, LUCENE-5952.patch, LUCENE-5952.patch, > LUCENE-5952.patch > > > As discussed on the dev list, it's spooky how Version.java tries to fully > parse the incoming version string ... and then throw exceptions that lack > details about what invalid value it received, which file contained the > invalid value, etc. > It also seems too low level to be checking versions (e.g. is not future proof > for when 4.10 is passed a 5.x index by accident), and seems redundant with > the codec headers we already have for checking versions? > Should we just go back to lenient parsing? -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org