[
https://issues.apache.org/jira/browse/SOLR-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy Potter updated SOLR-6511:
---------------------------------
Attachment: SOLR-6511.patch
Here's an updated patch. It'll need to be updated again after SOLR-6530 is
committed. Key things in this patch are:
1) HttpPartitionTest.testLeaderZkSessionLoss: reproduces the scenario described
in this ticket
2) DistributedUpdateProcessor now checks to see if the reason for a failure is
because of a leader change and if so, the request fails and an error is sent to
the client
I had to add a way to pass-thru some additional context information about an
error from server to client, which I'll do that work in another ticket but this
patch shows the approach I'm taking.
Lastly, HttpPartitionTest continues to be a problem - I beast'd it for 10 times
and it failed after 6 runs locally (sometimes fewer), so will need to get that
problem resolved before committing this patch too. It consistently fails in the
testRf3WithLeaderFailover but for different reasons. My thinking is that I'll
break the problem test case (testRf3WithLeaderFailover) out to its own test
class as the other tests in this class work well and cover a lot of important
functionality.
> Fencepost error in LeaderInitiatedRecoveryThread
> ------------------------------------------------
>
> Key: SOLR-6511
> URL: https://issues.apache.org/jira/browse/SOLR-6511
> Project: Solr
> Issue Type: Bug
> Reporter: Alan Woodward
> Assignee: Timothy Potter
> Attachments: SOLR-6511.patch, SOLR-6511.patch
>
>
> At line 106:
> {code}
> while (continueTrying && ++tries < maxTries) {
> {code}
> should be
> {code}
> while (continueTrying && ++tries <= maxTries) {
> {code}
> This is only a problem when called from DistributedUpdateProcessor, as it can
> have maxTries set to 1, which means the loop is never actually run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
