[
https://issues.apache.org/jira/browse/LUCENE-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142405#comment-14142405
]
ASF subversion and git services commented on LUCENE-5948:
---------------------------------------------------------
Commit 1626557 from [~mikemccand] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1626557 ]
LUCENE-5948: RateLimiter now fully inits itself on init
> Improve RateLimiters Initialization semantics
> -----------------------------------------------
>
> Key: LUCENE-5948
> URL: https://issues.apache.org/jira/browse/LUCENE-5948
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Varun Thacker
> Fix For: 5.0, 6.0
>
> Attachments: LUCENE-5948.patch
>
>
> I was working on SOLR-6485 when I realized that the first time pause is
> called even if we write a lot of bytes pause doesn't work correctly because
> in SimpleRateLimiter.pause() lastNS is 0 and startNS is always more than
> targetNS.
> If we remove the following line from TestRateLimiter.testPause() then the
> test fails -
> {code}
> limiter.pause(2);//init
> {code}
> Should we do one of the following ?
> 1. Initialize lastNS in the ctor {code}lastNS = System.nanoTime();{code}
> 2. Add a method saying start() which does the same
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
