[
https://issues.apache.org/jira/browse/SOLR-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148316#comment-14148316
]
Tomás Fernández Löbbe commented on SOLR-6541:
---------------------------------------------
bq. We can remove the map. I'll take a look
OK, I see that in order to remove the map we need to restore the lookupOrd for
all the docs with missing values, or do a bigger refactor (something like
making {{facetStatsValues}} also use ords instead of terms, however, this is
used from both stats implementations so I don't know how much of an impact this
is yet).
That said, and given that we are trying to move the "stats' facet" to the
"pivot faceting" (SOLR-6351), I don't know if it make sense to spend all the
effort this issue would require, it probably makes more sense to spent that
effort in SOLR-6351.
> Enhancement for SOLR-6452 StatsComponent "missing" stat won't work with
> docValues=true and indexed=false
> --------------------------------------------------------------------------------------------------------
>
> Key: SOLR-6541
> URL: https://issues.apache.org/jira/browse/SOLR-6541
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 4.10, Trunk
> Reporter: Vitaliy Zhovtyuk
> Priority: Minor
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6541.patch
>
>
> This issue is refactoring of solution provided in SOLR-6452 StatsComponent
> "missing" stat won't work with docValues=true and indexed=false.
> I think the following points need to be addressed:
> 1. Accumulate methods should not return stats specific numbers (it is
> generic). Attached solution with container class. Also made them private
> scoped.
> Returning just missing fields from accumulate methods does not allow you to
> extend it with additional counts field, therefore i propose to leave void.
> 2. Reduced visibility of fields in FieldFacetStats.
> 3. Methods FieldFacetStats#accumulateMissing and
> FieldFacetStats#accumulateTermNum does not throw any IO exception
> 4. We don't need intermediate maps to accumulate missing counts. Method
> org.apache.solr.handler.component.FieldFacetStats#facetMissingNum
> can be changed to work directly on StatsValues structure and removed
> org.apache.solr.handler.component.FieldFacetStats#accumulateMissing.
> We don't need to have it in 2 phases.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
