Robert Muir created LUCENE-5988:
-----------------------------------
Summary: Tighten up IW's CFS codepath
Key: LUCENE-5988
URL: https://issues.apache.org/jira/browse/LUCENE-5988
Project: Lucene - Core
Issue Type: Bug
Reporter: Robert Muir
I wanted to tackle this really in LUCENE-5969, but I found dragons here.
* the handling of si.files() logic as it relates to compound files is
inconsistent. For instance, flush passes trackingdirectorywrapper and has some
logic, but merge/addindexes pass the raw directory and track things
differently. Ideally we would just use trackingwrapper consistently, and remove
CompoundFormat.files().
* merge exception handling is scary: it manually snipes CFS files with
indexfiledeleter when exceptions happen, which scares me a lot. I can also "see
things that look like bugs" in this code. Maybe we can clean this up
(especially if si.files is no longer crazy) and just somehow do a
ifd.refresh(newseg) in all cases? Somewhat related is LUCENE-5987 but this
would be a simpler step.
* the timing around setting useCFS boolean is really awkward, e.g. the codec
will see false when writing CFS files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
