[
https://issues.apache.org/jira/browse/LUCENE-5991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160085#comment-14160085
]
Michael McCandless commented on LUCENE-5991:
--------------------------------------------
+1
> add minor-revision writers to backwards-codecs
> ----------------------------------------------
>
> Key: LUCENE-5991
> URL: https://issues.apache.org/jira/browse/LUCENE-5991
> Project: Lucene - Core
> Issue Type: Test
> Reporter: Robert Muir
>
> Today we have backwards testing almost completely isolated cleanly, and tests
> against each format. But we only test old major formats, not the minor ones.
> Before it was probably the right tradeoff, but now that its isolated I think
> we should test all of them.
> For example the 4.1 stored fields format had two minor format changes across
> the 4.x release:
> {noformat}
> static final int VERSION_START = 0;
> static final int VERSION_BIG_CHUNKS = 1;
> static final int VERSION_CHECKSUM = 2;
> static final int VERSION_CURRENT = VERSION_CHECKSUM;
> {noformat}
> We could easily directly test these possibilities (e.g. take this as a
> parameter to the RW format and have 3 TestXXXStoredFieldsFormat, one for
> each) instead of only testing the latest one and relying on TestBackCompat to
> find issues, which it probably won't since the index is simplistic.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
