[
https://issues.apache.org/jira/browse/LUCENE-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160202#comment-14160202
]
Uwe Schindler commented on LUCENE-5992:
---------------------------------------
I am fine with both options. For me it is important that Version has no public
ctor (under no circumstances), so people using Eclipse autocomplete do not
"naturally" use the ctor to pass version constants to analyzers or other stuff
in other public APIs. This will cause endless bug reports. A separate static
method should be preferred here, because it has a "method name" that explains
what it does. The eclipse user has to choose carefully and cannot automatically
use the worst option.
> Version should not be encoded as a String in the index
> ------------------------------------------------------
>
> Key: LUCENE-5992
> URL: https://issues.apache.org/jira/browse/LUCENE-5992
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, Trunk
>
> Attachments: LUCENE-5992.patch
>
>
> The version is really "just" 3 (maybe 4) ints under-the-hood, but today we
> write it as a String which then requires spooky string tokenization/parsing
> when we open the index. I think it should be encoded directly as ints.
> In LUCENE-5952 I had tried to make this change, but it was controversial, and
> got booted.
> Then in LUCENE-5969, I tried again, but that issue has morphed (nicely!) into
> fixing all sorts of things *except* these three ints.
> Maybe 3rd time's a charm ;)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
