[ 
https://issues.apache.org/jira/browse/LUCENE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163031#comment-14163031
 ] 

Robert Muir commented on LUCENE-5997:
-------------------------------------

Surely "affects version 4.10" is just a mistake: take a look at what the code 
does in 4.10.

I agree: nuke it for 5.0, but the reason it has been "doing nothing" for years 
is because its not "doing nothing", but presumably still supporting backwards 
compatibility for 5-year-old indexes (3.0.x).

Currently, both indexes and analysis chains from 3.0 have to be supported all 
the way up to 5.0, which leaves a good deal of backwards compat cruft around 
for years and years and years.


> StandardFilter redundant
> ------------------------
>
>                 Key: LUCENE-5997
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5997
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 4.10.1
>            Reporter: Itamar Syn-Hershko
>            Priority: Trivial
>
> Any reason why StandardFilter is still around? its just a no-op class now:
>   @Override
>   public final boolean incrementToken() throws IOException {
>     return input.incrementToken(); // TODO: add some niceties for the new 
> grammar
>   }
> https://github.com/apache/lucene-solr/blob/trunk/lucene/analysis/common/src/java/org/apache/lucene/analysis/standard/StandardFilter.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to