[ 
https://issues.apache.org/jira/browse/SOLR-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163452#comment-14163452
 ] 

Jan Høydahl commented on SOLR-6572:
-----------------------------------

I think it's dangerous to always strip whitespace when parsing XML, cause there 
may be cases where they are significant. Better to fix it for {{masterUrl}} and 
{{shards}}?

> lineshift in solrconfig.xml is not supported
> --------------------------------------------
>
>                 Key: SOLR-6572
>                 URL: https://issues.apache.org/jira/browse/SOLR-6572
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.8.1
>            Reporter: Fredrik Rodland
>              Labels: solrconfig.xml
>
> This has been a problem for a long time, and is still a problem at least for 
> SOLR 4.8.1.
> If lineshifts are introduced in some elements in solrconfig.xml SOLR fails to 
> pick up on the values.
> example:
> ok:
> {code}
>     <requestHandler name="/replication" class="solr.ReplicationHandler" 
> enable="${enable.replication:false}">
>         <lst name="slave">
>             <str 
> name="masterUrl">${solr.master.url:http://solr-admin1.finn.no:12910/solr/front-static/replication}</str>
> {code}
> not ok:
> {code}
>     <requestHandler name="/replication" class="solr.ReplicationHandler" 
> enable="${enable.replication:false}">
>         <lst name="slave">
>             <str 
> name="masterUrl">${solr.master.url:http://solr-admin1.finn.no:12910/solr/front-static/replication}
> </str>
> {code}
> Other example:
> ok:
> {code}
>             <str 
> name="shards">localhost:12100/solr,localhost:12200/solr,localhost:12300/solr,localhost:12400/solr,localhost:12500/solr,localhost:12530/solr</str>
> {code}
> not ok:
> {code}
>             <str name="shards">
> localhost:12100/solr,localhost:12200/solr,localhost:12300/solr,localhost:12400/solr,localhost:12500/solr,localhost:12530/solr
>            </str>
> {code}
> IDEs and people tend to introduce lineshifts in xml-files to make them 
> prettyer.  SOLR should really not be affected by this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to