[
https://issues.apache.org/jira/browse/SOLR-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14163655#comment-14163655
]
ASF GitHub Bot commented on SOLR-6604:
--------------------------------------
GitHub user cpoerschke opened a pull request:
https://github.com/apache/lucene-solr/pull/98
distributed expand=true&fl=key NPE fix, expand=true&distrib.singlePass=true
consideration
https://issues.apache.org/jira/i#browse/SOLR-6604
scenario:
* select?expand=true&fl=key hit NPE in ExpandComponent.handleResponse when
the responses of the EXECUTE_QUERY contained no expanded element despite the
requests' purpose including PURPOSE_GET_FIELDS
* select?expand=true&distrib.singlePass=true worked but relied on other
preceding components triggering a GET_FIELDS stage
changes:
* add TestExpandComponent and DistributedExpandComponentTest test cases
* change code to fix NPE
* change code to avoid distrib.singlePass reliance on other components
* tweak test cases to randomly alternate between docValues=false and
docValues=true collapse fields
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/lucene-solr trunk-collapse-expand
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit c7c79f24230e3f6470e3ee58c9e58346dc1b043b
Author: Christine Poerschke <[email protected]>
Date: 2014-09-08T10:06:41Z
solr: distributed select?expand=true&fl=key NPE fix,
select?expand=true&distrib.singlePass=true consideration
scenario:
* select?expand=true&fl=key hit NPE in ExpandComponent.handleResponse when
the responses of the EXECUTE_QUERY contained no expanded element despite the
requests' purpose including PURPOSE_GET_FIELDS
* select?expand=true&distrib.singlePass=true worked but relied on other
preceding components triggering a GET_FIELDS stage
changes:
* add TestExpandComponent and DistributedExpandComponentTest test cases
* change code to fix NPE
* change code to avoid distrib.singlePass reliance on other components
* tweak test cases to randomly alternate between docValues=false and
docValues=true collapse fields
----
> distributed expand=true&fl=key NPE fix, expand=true&distrib.singlePass=true
> consideration
> -----------------------------------------------------------------------------------------
>
> Key: SOLR-6604
> URL: https://issues.apache.org/jira/browse/SOLR-6604
> Project: Solr
> Issue Type: Bug
> Reporter: Christine Poerschke
> Priority: Minor
>
> select?expand=true&fl=key hits NPE in ExpandComponent.handleResponse when the
> responses of the EXECUTE_QUERY contain no expanded element despite the
> requests' purpose including PURPOSE_GET_FIELDS
> select?expand=true&distrib.singlePass=true works but relies on other
> preceding components triggering a GET_FIELDS stage
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
