[ 
https://issues.apache.org/jira/browse/SOLR-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruno Roustant updated SOLR-6613:
---------------------------------
    Description: 
In TextField.analyzeMultiTerm()
at line
try {
  if (!source.incrementToken())
    throw new SolrException();

The method should not throw an exception if there is no token because having no 
token is legitimate because all tokens may be filtered out (e.g. with a 
blocking Filter such as StopFilter).

In this case it should simply return null (as it already returns null in some 
cases, see first line of method). However, SolrQueryParserBase needs also to be 
fixed to correctly handle null returned by TextField.analyzeMultiTerm().

See attached TestTextField for the corresponding new test class.

  was:
In TextField.analyzeMultiTerm()
at line
try {
  if (!source.incrementToken())
    throw new SolrException();

The method should not throw an exception if there is no token because having no 
token is legitimate because all tokens may be filtered out (e.g. with a 
blocking Filter such as StopFilter).

In this case it should simply return null (as it already returns null in some 
cases, see first line of method).


> TextField.analyzeMultiTerm should not throw exception when analyzer returns 
> no term
> -----------------------------------------------------------------------------------
>
>                 Key: SOLR-6613
>                 URL: https://issues.apache.org/jira/browse/SOLR-6613
>             Project: Solr
>          Issue Type: Bug
>          Components: Schema and Analysis
>    Affects Versions: 4.3.1, 4.10.2, Trunk
>            Reporter: Bruno Roustant
>         Attachments: TestTextField.java
>
>
> In TextField.analyzeMultiTerm()
> at line
> try {
>   if (!source.incrementToken())
>     throw new SolrException();
> The method should not throw an exception if there is no token because having 
> no token is legitimate because all tokens may be filtered out (e.g. with a 
> blocking Filter such as StopFilter).
> In this case it should simply return null (as it already returns null in some 
> cases, see first line of method). However, SolrQueryParserBase needs also to 
> be fixed to correctly handle null returned by TextField.analyzeMultiTerm().
> See attached TestTextField for the corresponding new test class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to