[
https://issues.apache.org/jira/browse/SOLR-6615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166243#comment-14166243
]
Yonik Seeley commented on SOLR-6615:
------------------------------------
+1, but not the test code please...
IMO, If constants are used in test code, they should be different constants
than those used in the normal code. Otherwise an accidental change of a string
constant (either a typo, or someone making a deliberate change and not
realizing the full scope of the change - like everywhere the constant is used)
won't cause anything to fail.
> Refactor code to use String constants
> -------------------------------------
>
> Key: SOLR-6615
> URL: https://issues.apache.org/jira/browse/SOLR-6615
> Project: Solr
> Issue Type: Task
> Reporter: Noble Paul
>
> Solr codebase is full of string constants used in place and the same string
> is declared in multiple places . We need to define the constants in a common
> place and need to reuse them
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
