[ 
https://issues.apache.org/jira/browse/SOLR-6511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shalin Shekhar Mangar reopened SOLR-6511:
-----------------------------------------

Tim, the change to the LIR state to be kept as map is not back-compatible. For 
example, I saw the following error upon upgrading a cluster (to trunk) (which 
had some LIR state written down in ZK already). But looking at the code, the 
same exception can happen on upgrading to latest lucene_solr_4_10 branch too.

{code}
41228 [RecoveryThread] ERROR org.apache.solr.cloud.RecoveryStrategy   Error 
while trying to recover. 
core=coll_5x3_shard5_replica3:java.lang.ClassCastException: java.lang.String 
cannot be cast to java.util.Map
        at 
org.apache.solr.cloud.ZkController.getLeaderInitiatedRecoveryStateObject(ZkController.java:1993)
        at 
org.apache.solr.cloud.ZkController.getLeaderInitiatedRecoveryState(ZkController.java:1958)
        at org.apache.solr.cloud.ZkController.publish(ZkController.java:1105)
        at org.apache.solr.cloud.ZkController.publish(ZkController.java:1075)
        at org.apache.solr.cloud.ZkController.publish(ZkController.java:1071)
        at 
org.apache.solr.cloud.RecoveryStrategy.doRecovery(RecoveryStrategy.java:355)
        at org.apache.solr.cloud.RecoveryStrategy.run(RecoveryStrategy.java:235)

{code}

> Fencepost error in LeaderInitiatedRecoveryThread
> ------------------------------------------------
>
>                 Key: SOLR-6511
>                 URL: https://issues.apache.org/jira/browse/SOLR-6511
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Alan Woodward
>            Assignee: Timothy Potter
>             Fix For: 4.10.2, 5.0
>
>         Attachments: SOLR-6511.patch, SOLR-6511.patch
>
>
> At line 106:
> {code}
>     while (continueTrying && ++tries < maxTries) {
> {code}
> should be
> {code}
>     while (continueTrying && ++tries <= maxTries) {
> {code}
> This is only a problem when called from DistributedUpdateProcessor, as it can 
> have maxTries set to 1, which means the loop is never actually run.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to